Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Add UDF Section #752

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Draft: Add UDF Section #752

wants to merge 3 commits into from

Conversation

proddata
Copy link
Member

@proddata proddata commented Oct 23, 2021

Summary of the changes / Why this is an improvement

Adding a view for User Defined Functions helps to manage and replace UDFs within CrateDB.
Before one would need to manually manage UDFs outside of CrateDB and/or remember queries like.

SELECT *
FROM information_schema.routines
WHERE routine_type = 'FUNCTION';

to check which UDFs exist within CrateDB

image

forked from Views-view / section

Open To-Dos:

  • Find or Create a suitable icon for sidebar
  • Find a solution to translate internal data types like integer_array to ARRAY(INTEGER)
  • Finish Create or Replace functionality
  • Add correct translations (i18n)
  • General cleanup (As this was derived from the views view)

closes #734

Checklist

  • CLA is signed

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this feature, thanks for working on it.

app/scripts/controllers/common.js Outdated Show resolved Hide resolved
app/static/i18n/en.json Outdated Show resolved Hide resolved
@@ -23,6 +23,7 @@
"OVERVIEW": "Overview",
"CONSOLE": "Console",
"TABLE": "Tables",
"UDF": "User Defined Functions",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will happen when switching to another language?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add the i18n translations when the rest is done :)

@amotl
Copy link
Member

amotl commented Jun 3, 2022

Hi Georg,

I was just scanning the unmerged patches and found this. Did you plan to add more things before unflagging the "Draft" mode?

With kind regards,
Andreas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include view for User Defined Functions (UDFs)
2 participants